tests: fix tests Grant and Revoke NoSu #516
Open
+37
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed tests. Now, tests follow new Tarantool behavior (about 'grant' and 'revoke' privileges). Closes #511
laines-it
force-pushed
the
laines-it/gh-511-fix-tests-Grant-Revoke-WithoutSu
branch
from
95f10d1 to
b774ce9
Compare
oleg-jukovec
requested changes
Dec 23, 2025
Collaborator
There was a problem hiding this comment.
The tests name is:
TestBox_Sugar_Schema_UserGrant_NoSu
and:
TestSchemaUser_Revoke_WithoutSu
But in the updated tests we actually do the su. It is very strange now. I suggest the following:
It will be better to create another user (testsu?) inside testdata/config.lua without grant access and use it for creating a connection in tests TestBox_Sugar_Schema_UserGrant_NoSu/TestBox_Sugar_Schema_UserGrant_Su. In that case you will not need to modify the tests structure.
Collaborator
Author
There was a problem hiding this comment.
Maybe we better change names
TestBox_Sugar_Schema_UserGrant_NoSu->TestBox_Sugar_Schema_UserGrant_AccessDenied(orTestSchemaUser_Grant_AccessDenied)TestSchemaUser_Revoke_WithoutSu->TestSchemaUser_Revoke_AccessDeniedTestBox_Sugar_Schema_UserGrant_WithSu->TestBox_Sugar_Schema_UserGrant(orTestSchemaUser_Grant)TestSchemaUser_Revoke_WithSu->TestSchemaUser_Revoke?
It will keep config the same, I think it would be too complicated otherwise. Also, we can remove these Su lines, since they are unnecessary in new behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed tests.
Now, tests follow new Tarantool behavior
(about 'grant' and 'revoke' privileges).
Closes #511